Lily/ClonesPlus: revert breaking change #2110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: change existing extension
|
Well now this ‘breaks’ projects using the new change |
|
this is a very unfortuante situation but probably since there hasnt been a desktop app update with this, it can be feasibly reverted, ... |
yuri-kiss
approved these changes
May 15, 2025
GarboMuffin
approved these changes
May 21, 2025
GarboMuffin
changed the title
CubesterYT
pushed a commit
that referenced
this pull request
May 21, 2025
…riginal (#2123) context: #2110 re-fixes: #1421 --------- Co-authored-by: DangoCat[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5825ea7
This change breaks projects made with previous versions of the extension. This is was a change in functionality!
One of my projects is affected by this change, because it is built with clones starting with empty local variables in mind. This should be handled differently. I dont know how this was approved. You cant change stuff like this after such a long time of them working this way, without making sure that old projects are unaffected